Skip to content

Fix EndpointSlice deserialization when endpoints is null #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Gautam-aman wants to merge 1 commit into from
Closed

Fix EndpointSlice deserialization when endpoints is null #4507

Gautam-aman wants to merge 1 commit into from
+21 −34

Conversation

@Gautam-aman
Copy link
Contributor

@Gautam-aman Gautam-aman commented Jan 9, 2026

Allow V1EndpointSlice to deserialize correctly when the Kubernetes API returns "endpoints": null.
The model validation is relaxed to accept null while still validating array contents when present.

Duplicate and unused imports were also removed during cleanup.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gautam-aman
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2026
@brendandburns
Copy link
Contributor

brendandburns commented Jan 12, 2026

Unfortunately, this code is generated, so we can't take edits to this file, if you want to make changes it needs to be in the upstream open API code generator:

https://github.com/OpenAPITools/openapi-generator

@brendandburns
Copy link
Contributor

brendandburns commented Jan 12, 2026 •
edited
Loading

Also, specifically for this, I believe that this is because the Kubernetes API spec definition does not say that null values are allowed here.

Ah, I see that the spec was revised. We should pick this up the next time that we regenerate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@yue9944882 yue9944882 Awaiting requested review from yue9944882

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gautam-aman @k8s-ci-robot @brendandburns